feat: enable Multi-Tenancy in PresentationApi #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
added
enhancement
paullatzelsperger
changed the title
paullatzelsperger
force-pushed
the
fix/259_enable_multitenancy_in_presentationcreatorregistry
branch
from
a3e0986
to
973afc8
Compare
bscholtes1A
approved these changes
Feb 6, 2024
wolf4ood
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR adds "multi-tenancy" to the presentation API by adding the following aspects:
participants/{participantId}path to the Presentation APIParticipantContextwith that ID actually existsparticipantIdthrough all layers of the presentation generationAccessTokenVerifierto verify that theparticipantContextIdmatches theaccess_token.audclaimPresentationCreatorRegistryImplso that it uses theKeyPairServiceto obtain the correct key-id for the participantWhy it does that
multi-tenancy was not implemented when the presentation API was first created
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes #259
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.