feat: make DidManagementApi more explicit #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
added
refactoring
|
will require #227 |
paullatzelsperger
force-pushed
the
feat/220_make_didmanagementapi_more_specific
branch
from
17a29c6
to
b299860
Compare
paullatzelsperger
deleted the
feat/220_make_didmanagementapi_more_specific
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR removes generic endpoints from the DidManagementAPI, such as create, update or delete. Instead, they have been replaced with more focused endpoints for adding
serviceEndpointentriesto a DID document.
Why it does that
For the purposes of IdentityHub, the DID document is a fully managed piece of information, that is merely a representation of a particular participant. Thus,
manually modifying that document can cause inconsistencies.
Further notes
DidDocumentServicehas been adapted too, to reflect those changes.Linked Issue(s)
Closes #220
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.