refactor: incorporate latest EDC refactorings #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
added
enhancement
paullatzelsperger
force-pushed
the
refactor/incorporate_edc_token_refactoring
branch
from
6afbbd6
to
43342d1
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...als/src/main/java/org/eclipse/edc/identityhub/token/verification/AudienceValidationRule.java
Fixed
Show fixed
Hide fixed
paullatzelsperger
force-pushed
the
refactor/incorporate_edc_token_refactoring
branch
from
cea9cbb
to
fc513ff
Compare
wolf4ood
approved these changes
Jan 14, 2024
ndr-brt
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR updates the IH implementation to reflect the latest upstream EDC changes introduced in eclipse-edc/Connector#3774.
In particular the following changes are done:
AccessTokenVerifiernow usesTokenValidationServiceplusTokenValidationRulesJwtPresentationGeneratorusesJwtGenerationServiceplusTokenDecoratorsWhy it does that
Leverage the streamlined token and security key handling
Further notes
will not compile/build until refactor: streamline handling of tokens in EDC Connector#3774 is merged! I developed it with a local maven build.Linked Issue(s)
Related to eclipse-edc/Connector#3774
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.