chore: publish IdentityHub API to SwaggerHub #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
added
documentation
paullatzelsperger
force-pushed
the
chore/publish_to_swaggerhub
branch
from
24266fc
to
730452a
Compare
wolf4ood
approved these changes
Dec 27, 2023
paullatzelsperger
added a commit
to paullatzelsperger/IdentityHub
that referenced
this pull request
Dec 28, 2023
* chore: publish IH API to SwaggerHub * fix api * DEPENDENCIES
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Adds a GH Actions workflow that publishes the (generated) OpenAPI spec to SwaggerHub.
Why it does that
Documentation
Further notes
I also converted all
DELETE /...endpoints toPOST /.../deleteendpoints, because SwaggerHub complained that "DELETE calls cannot contain request bodies". The spec isn't super specific on the topic and doesn't explicitly forbid it, but upon further investigation, I read that some load balancers and API gateways may discard or even reject DELETE requests with a 400 that contain a body.Linked Issue(s)
Closes #206
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.