fix: various smaller fixes for IATP #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This is a collection PR for the following minor improvements/fixes:
LdpPresentationCreator: add proof purpose and verification method properties when signing LDP-VPsCredentialQueryResolver: execute actual database query when comparing issuer and prover scope. This was necessary because the in-memory predicate does not properly map the credential typesPresentationGenerator: pass additional data to VP creators (e.g. "aud" for JWT-VPs)AccessTokenVerifierImpl: only issue a warning when proof-of-possession was not established. This is a specific issue when the Participant ID and the token subject are not equalWhy it does that
These issues arose during end-to-end testing and setting up a demo installation
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.