feat: implement CredentialQueryResolver #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
requested review from
jimmarino,
wolf4ood,
ndr-brt and
bscholtes1A
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.../identity-hub-core/src/main/java/org/eclipse/edc/identityhub/core/CoreServicesExtension.java
Fixed
Show fixed
Hide fixed
jimmarino
approved these changes
Nov 8, 2023
core/identity-hub-core/src/main/java/org/eclipse/edc/identityhub/DefaultServicesExtension.java
Outdated
Show resolved
Hide resolved
ndr-brt
reviewed
Nov 8, 2023
...ity-hub-core/src/main/java/org/eclipse/edc/identityhub/core/CredentialQueryResolverImpl.java
Outdated
Show resolved
Hide resolved
...ity-hub-core/src/main/java/org/eclipse/edc/identityhub/core/CredentialQueryResolverImpl.java
Outdated
Show resolved
Hide resolved
...ity-hub-core/src/main/java/org/eclipse/edc/identityhub/core/CredentialQueryResolverImpl.java
Outdated
Show resolved
Hide resolved
...ity-hub-core/src/main/java/org/eclipse/edc/identityhub/core/CredentialQueryResolverImpl.java
Outdated
Show resolved
Hide resolved
...-core/src/main/java/org/eclipse/edc/identityhub/defaults/EdcScopeToCriterionTransformer.java
Show resolved
Hide resolved
…ub/DefaultServicesExtension.java Co-authored-by: Jim Marino <[email protected]>
ndr-brt
approved these changes
Nov 9, 2023
wolf4ood
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR implements the
CredentialQueryResolverthat accepts a presentation query and returns a list of VerifiableCredentials.It also adds a default Scope-to-Criterion converter.
Why it does that
Being able to query the database based off of a scope string.
Further notes
UnsupportedOperationException.EdcScopeToCriterionTransformeris intended for demo purposes only, do not use it in production code!Linked Issue(s)
Closes #153
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.