Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Presentation API: add support for multi-tenancy #259

Closed
paullatzelsperger opened this issue Feb 5, 2024 · 0 comments · Fixed by #263
Closed

Presentation API: add support for multi-tenancy #259

paullatzelsperger opened this issue Feb 5, 2024 · 0 comments · Fixed by #263
Assignees
@paullatzelsperger
Labels
enhancement New feature or request

Comments

@paullatzelsperger
Copy link
Member

paullatzelsperger commented Feb 5, 2024 •
edited
Loading

Bug Report

Describe the Bug

Currently, the PresentationCreatorRegistryImpl contains a mapping of credential format -> key-id. That scheme only can accommodate one key per format. As soon as there is another participant, the existing keys would get overwritten.

Expected Behavior

The PresentationCreatorRegistryImpl returns the (first) default key for every participant.

Possible Implementation

The PresentationCreatorRegistryImpl obtains all active (non-rotated, non-revoked) keys for a participant context where the isDefault flag is set. If there are several, take the first one. If there is no default key, take one at random. If there is no active key, abort with an error.

Maintaining an in-memory map is not sufficient. The KeyPairResourceService must be consulted.
@paullatzelsperger paullatzelsperger added bug_report Suspected bugs, awaiting triage triage all new issues awaiting classification labels Feb 5, 2024
@paullatzelsperger paullatzelsperger self-assigned this Feb 5, 2024
@paullatzelsperger paullatzelsperger added bug Something isn't working and removed triage all new issues awaiting classification bug_report Suspected bugs, awaiting triage labels Feb 5, 2024
@paullatzelsperger paullatzelsperger mentioned this issue Feb 5, 2024
Merged
@paullatzelsperger paullatzelsperger changed the title PresentationCreatorRegistryImpl: invert key-id mapping to enable multi-tenancy Presentation API: add support for multi-tenancy Feb 5, 2024
@paullatzelsperger paullatzelsperger added enhancement New feature or request and removed bug Something isn't working labels Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paullatzelsperger paullatzelsperger

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: enable Multi-Tenancy in PresentationApi paullatzelsperger/IdentityHub
1 participant
@paullatzelsperger