fix: explicit modification of roles (#258)

fix: implement explicit setting of roles
eclipse-edc · Feb 5, 2024 · c800847 · c800847
1 parent 53b8249
commit c800847
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/...rg/eclipse/edc/identityhub/api/participantcontext/v1/ParticipantContextApiController.java b/...rg/eclipse/edc/identityhub/api/participantcontext/v1/ParticipantContextApiController.java
@@ -108,10 +108,7 @@ public void deleteParticipant(@PathParam("participantId") String participantId,
     @Path("/{participantId}/roles")
     @RolesAllowed(ServicePrincipal.ROLE_ADMIN)
     public void updateRoles(@PathParam("participantId") String participantId, List<String> roles) {
-        participantContextService.updateParticipant(participantId, participantContext -> {
-            participantContext.getRoles().clear();
-            participantContext.getRoles().addAll(roles);
-        }).orElseThrow(exceptionMapper(ParticipantContext.class, participantId));
+        participantContextService.updateParticipant(participantId, participantContext -> participantContext.setRoles(roles)).orElseThrow(exceptionMapper(ParticipantContext.class, participantId));
     }
 
 }
diff --git a/...i/src/main/java/org/eclipse/edc/identityhub/spi/model/participant/ParticipantContext.java b/...i/src/main/java/org/eclipse/edc/identityhub/spi/model/participant/ParticipantContext.java
@@ -22,6 +22,7 @@
 
 import java.time.Instant;
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.List;
 import java.util.Objects;
 
@@ -100,7 +101,11 @@ public String getDid() {
     }
 
     public List<String> getRoles() {
-        return roles;
+        return Collections.unmodifiableList(roles);
+    }
+
+    public void setRoles(List<String> roles) {
+        this.roles = roles;
     }
 
     @JsonPOJOBuilder(withPrefix = "")