Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Amazon S3 integration for assets and transfers #18

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

kandakji
Copy link

What this PR changes/adds

Briefly describe WHAT your pr changes, which features it adds/modifies.

The PR changes include added functionalities around S3 storage where I added:
. Ability to create assets referencing s3 objects
. Ability to transfer assets to an s3 sink (a bucket is provisioned in eu-west-1 if the bucket and the region are not provided in the transfer popup)

Why it does that

Briefly state why the change was necessary.

It extends the datadashboard functionality to support a additional data plane being S3

Further notes

List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.

Linked Issue(s)

Closes # <-- insert Issue number if one exists

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@paullatzelsperger paullatzelsperger self-requested a review May 10, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant