Disable multiple receive threads by default #1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On non-Windows platforms, the default was to use multiple receive threads, which in turn implied the use of blocking read operations. On termination, those blocking calls were interrupted by sending a packet to itself, but that only works if the firewall allows it. If the firewall drops these packet, the process hangs. Various people have run into this problem, changing to using a single thread always solves the problem. So, changing the default until a better solution for interrupting these calls is implemented is probably for the best. Signed-off-by: Erik Boasson <[email protected]>
|
It is somewhat against my principle to merge something while CI is broken, but the change here has nothing to do with the CI problems, the macOS It is probably better to merge this now than to wait for the OpenSSL thing to be completely solved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On non-Windows platforms, the default was to use multiple receive threads, which in turn implied the use of blocking read operations. On termination, those blocking calls were interrupted by sending a packet to itself, but that only works if the firewall allows it. If the firewall drops these packet, the process hangs.
Various people have run into this problem, changing to using a single thread always solves the problem. So, changing the default until a better solution for interrupting these calls is implemented is probably for the best.
Fixes #1916