Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write-like operations: consistent check of data/timestamp #1890

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Write-like operations: consistent check of data/timestamp #1890

merged 1 commit into from
Nov 30, 2023

Commits on Nov 30, 2023

  1. write-like ops: consistent check of data/timestamp 

    Some functions, notable dds_write_ts rejected negative time stamps, a
choice that I think is reasonable.

Unregister and dispose did not always check, but those occur necessarily
after a write, and therefore allowing negative time stamps if they are
rejected by a write operation makes no sense.  So adding a check here is
a bug fix.

All write-like functions taking a data argument check for a null pointer
before anything else.  dds_writedispose_ts failed to do this, which then
results in a different error code.  That bug is also fixed here.

Signed-off-by: Erik Boasson <[email protected]>
    @eboasson
    eboasson committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    c245299 View commit details
    Browse the repository at this point in the history