dynsub: fix bounded strings #1812
Conversation
Signed-off-by: Erik Boasson <[email protected]>
| printf ("\"%s\"", p); | ||
| else | ||
| printf ("\"%s\"", *((const char **) p)); |
There was a problem hiding this comment.
I wanted to clarify my comprehension that this is involving some sort of small string/sequence optimization where the characters are immediately available at p for small strings but requires pointer indirection otherwise?
There was a problem hiding this comment.
Someone way back when (not me, I just inherited it) chose to map bounded strings to inlined arrays of characters, even though the IDL-to-C mapping specifies it is a pointer just like an unbounded string.
There is a reasonable argument: this is one of very few decent ways to support bounded strings without requiring memory allocation on reading samples. You can do preallocation of memory for sequences, structs, arrays, unions, ... anything, but not for strings in the official mapping. So it makes sense.
With XTypes, you can declare it @external and you'll get a pointer anyway if you really want. (dynsub isn't supporting that (yet).)
No description provided.