Add ENABLE_TYPELIB build option #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dpotman
force-pushed
the
typelib-build-option
branch
from
c1c07c7
to
ecb6992
Compare
eboasson
reviewed
Jul 27, 2023
|
These CodeQL issues were fixed with the force-push to ecb6992, but for some reason it seems that the new CodeQL run has used outdated header files for doing the checks. |
This adds the ENABLE_TYPELIB build option (default is ON) that controls including the type library (which stores the type meta-data for types used in local entities and in discovered proxy entities). The ENABLE_TYPELIB also controls the availability of the type-builder (to construct the type meta-data used by the serialized, e.g. used from the Python API) and the dynamic type API. Most of the functionality that can be disabled/enabled with this option was previously controlled by the ENABLE_TYPE_DISCOVERY build option. That option is also still available, but now only controls the inclusion of the type lookup functionality (that allows resolving type meta-data for types from discovery endpoints or topics). Signed-off-by: Dennis Potman <[email protected]>
dpotman
force-pushed
the
typelib-build-option
branch
from
ecb6992
to
6b52989
Compare
|
With my eyes I can't see what CodeQL sees. If CodeQL still complains after merging, we'll have another look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
ENABLE_TYPELIBbuild option (default isON) that controls including the type library (which stores the type meta-data for types used in local entities and in discovered proxy entities). TheENABLE_TYPELIBoption also controls the availability of the type-builder (to construct the type meta-data used by the serialized, e.g. used from the Python API) and the dynamic type API.Most of the functionality that can be disabled/enabled with this option was previously controlled by the
ENABLE_TYPE_DISCOVERYbuild option. That option is also still available, but now only controls the inclusion of the type lookup functionality (that allows resolving type meta-data for types from discovery endpoints or topics).The commit in this PR also include splitting the XTypes tests into multiple files, because that fits better with the new build options.