-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moves ostream_operators.hpp include to all implementation files #485
Conversation
@trittsv Good morning, can you take a look at this? |
Hey @michelle-vu19, seems that i missed that case described in #484. I put the include of the I strongly recommend to keep it in the cpp files. My suggestion is: |
@trittsv Thank you for the suggestion, I can get to this later today. |
@trittsv From a first glance, it seems like getting information from included IDL files is not something that can be done with the way the generator is set up (not saving information after parsing a single file). Is there a way to get information about an include file without reparsing? |
I'm running into this problem as well. Manually adding |
@trittsv @reicheratwork @eboasson Sorry for taking so long to apply this suggestion :) Can I get a review on this? I am currently in the process of compiling CPP types just to verify that this works. |
hey @michelle-vu19, looks good, you still need to sign the eclipsefdn/eca to be able to merge |
@trittsv Done! |
Update: my code generated successfully with the new changes :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change works fine for me! Resolving ostream_operators issues
When can this be merged? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am so sorry to have kept you waiting for so long @michelle-vu19
Resolves issue #484