authenticated remote signer requests #1985
Open
+76
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for taquito-test-dapp canceled.
|
|
Nice work @e-asphyx ! Can you revert/remove the updates to package-lock files, please? How trivial/cumbersome would it be to get unit tests added for this? Vs integration tests. I guess integration tests would either require mocking a signer server in typescript, or relying on a signatory instance? |
|
A new deploy preview is available on Netlify at https://c9702f9d--tezostaquito.netlify.app |
| @@ -32,6 +32,16 @@ await Tezos.contract.transfer({ to: publicKeyHash, amount: 2 }); | |||
|
|
|||
| The constructor of the `RemoteSigner` class requires the public key hash and the URL of the remote signer as parameters. It also takes optional headers (i.e., Authorization) and an optional `HttpBackend` to override the default one if needed. | |||
|
|
|||
| ### Authenticated requests | |||
| `RemoteSigner` can use an authenticated protocol. All you need is to pass a secret key in the Tezos Base58 format as `RemoteSignerOptions` property: | |||
There was a problem hiding this comment.
We could specify "The secret key shouldn't be associated with an onchain account"
|
Hello @e-asphyx Can you add tests to the PR? Let me know, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to Taquito.
Before submitting this PR, please make sure:
Release Note Draft Snippet
If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.