Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(etls): add all fields for DEVCO ETL - EUBFR-245 #196

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

kalinchernev
Copy link
Contributor

PR description

Add fields are added, I've tried to follow this logic:

  • SimpleValueField describes what has been discussed in the ticket about conventions. Targets mapping of single-value fields.
  • TypedValueField is adding field and type on top of SimpleValueField. Targets mapping of multi-value fields.
  • Other fields, which I could tell up front to be generic enough, I haven't prefixed with devco_, i.e. comments.
  • Fields with obvious/known types, i.e. dates, I have formatted as ISO dates.

QA Checklist

When you add a new ETL/producer, please check for the following:

  • Ensure the ETL has been correctly setup following the guide in services/ingestion/etl/README.md
  • There is at least 1 sample record.json and 1 unit test with a jest snapshot for the result of the transform function of the ETL.
  • Ensure there is (flow/jsdocs) documentation in the transform function
  • Generate the necessary documentation pages for the new ETL by yarn docs:md

@kalinchernev kalinchernev requested a review from a team February 15, 2019 15:09
@yhuard yhuard self-assigned this Feb 18, 2019
@yhuard yhuard changed the title refactor(etls) add all fields for DEVCO ETL - EUBFR-245 refactor(etls): add all fields for DEVCO ETL - EUBFR-245 Feb 18, 2019
@yhuard yhuard removed their assignment Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants