refactor(etls): add all fields for DEVCO ETL - EUBFR-245 #196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Add fields are added, I've tried to follow this logic:
SimpleValueField
describes what has been discussed in the ticket about conventions. Targets mapping of single-value fields.TypedValueField
is addingfield
andtype
on top ofSimpleValueField
. Targets mapping of multi-value fields.devco_
, i.e.comments
.QA Checklist
When you add a new ETL/producer, please check for the following:
services/ingestion/etl/README.md
record.json
and 1 unit test with a jest snapshot for the result of the transform function of the ETL.yarn docs:md