Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null error on removing children #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jakeane
Copy link

@jakeane jakeane commented Jul 22, 2021

Discovered issue when children are removed from the component. Results in this error

Uncaught TypeError: Cannot read property 'offsetTop' of null
    at _default._this.handleVerticalScroll (component.js:72)
    at _this.handleScroll (component.js:94)

Now null checks are performed in the problematic sections. This will avoid an error being raised unnecessarily.

Also, I removed the engine requirements, as they seem inconsequential.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant