Emit doctype, better match Apple's plist output #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've got no objections to fixing #26 and it would be good to have the output match Apple's native plist writer. But as this is hopefully a temporary fix I'd like it to be as minimal as possible. I think it we set |
|
Good idea. Not sure why that didn't occur to me. I'll try it out when I get a chance (hopefully tonight, but no promises). |
|
@ebarnard I've updated the PR to use the approach you suggested. |
This changes the plist writer output to more closely match Apple's plist output. More specifically, we capitalize the encoding, emit a doctype, and use hard tabs for indentation.
This matches how Apple's plist output works. In order to do this without completely taking over indentation duties ourselves, we just include the <plist> tag in the prologue, so xml-rs doesn't know about it, and then go ahead and emit an end event for the </plist> anyway since xml-rs doesn't particularly care.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the plist output to match Apple's. This means uppercasing the XML encoding, including a doctype, indenting using hard tabs, and stripping one level of indentation from the file.
The implementation here isn't great, because xml-rs doesn't have any way of emitting a doctype directly (see netvl/xml-rs#168), but it works.
Fixes #26.