Make path to temporary install directory used in test step of PythonPackage easyblock available through environment variable so that it may be used in easyconfigs
#3565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EasyCOnfigs. Needed by e.g. Astropy, that requires the tests to be ran in the installdir
1 task
boegel
reviewed
Jan 29, 2025
| @@ -851,6 +851,9 @@ def test_step(self, return_output_ec=False): | |||
| actual_installdir = os.path.join(test_installdir, 'local') | |||
| else: | |||
| actual_installdir = test_installdir | |||
| # Export the temporary installdir as an environment variable | |||
| # Some tests (e.g. for astropy) require to be run in the installdir | |||
| env.setvar('EB_TEST_INSTALLDIR', actual_installdir) | |||
There was a problem hiding this comment.
@casparvl Maybe EB_PYTHONPACKAGE_TEST_INSTALLDIR is better, to signal that this is only to be used for easyconfigs that rely on the PythonPackage easyblock?
boegel
changed the title
PythonPackage easyblock available through environment variable so that it may be used in easyconfigs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed by e.g. Astropy (easybuilders/easybuild-easyconfigs#22198), that requires the tests to be ran in the installdir