Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable OTEL_TRACES_EXPORTER for speed improvement #48

Merged
merged 1 commit into from
May 2, 2024
Merged

disable OTEL_TRACES_EXPORTER for speed improvement #48

merged 1 commit into from
May 2, 2024

Conversation

alexcb
Copy link
Contributor

@alexcb alexcb commented May 2, 2024

@alexcb alexcb requested a review from a team as a code owner May 2, 2024 21:17
idodod
idodod approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@idodod idodod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
We'll need to release manually
(a new release would generate new tags that include the date but would overwrite the existing tags that do not include the date)

@alexcb alexcb merged commit bb00ee9 into main May 2, 2024
2 checks passed
@alexcb alexcb deleted the acb/disable-otel-export branch May 2, 2024 21:33
@alexcb
Copy link
Contributor Author

alexcb commented May 2, 2024

We'll need to release manually

alternatively we could just wait for a new version of docker to come out; but that doesn't seem ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idodod idodod idodod approved these changes

@mikejholly mikejholly mikejholly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WITH DOCKER has 10 second delay
3 participants
@alexcb @mikejholly @idodod