-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle all 'how' values in df.join #249
base: main
Are you sure you want to change the base?
Conversation
Thanks for contributing this @Thomzoy! It would be great if we could at least get the left/right semi/anti cases added to the tests. Specifically the tests which demonstrate SQLFrame behaving the same as PySpark. See example here of a test showing that no on results in a cross join: sqlframe/tests/integration/test_int_dataframe.py Lines 882 to 896 in 250d86e
Let me know if this is something you are willing to do and if not I will look into opening a new PR with the change + tests added. |
aa95d22
to
ec60f7c
Compare
Included some test ! Another handled edge case: Spark treats a cross join with predicate as an inner join |
Nice! The different implicit behavior of Spark is hard to match so thanks for fixing that! |
@Thomzoy Looks like there is a merge conflict. Can you fix that and we will get this in? |
8e50799
to
e7e527a
Compare
Fixes #248