feat!: accept pd.DataFrame in session.createDataFrame #247
+33
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomzoy
changed the title
eakmanrq
reviewed
Jan 18, 2025
|
Great addition @Thomzoy! Can you add a test for this showing the conversion from pandas to PySpark? Might be good to add one to this file and show the same behavior between SQLFrame and PySpark when getting pandas dataframes as an input: https://github.com/eakmanrq/sqlframe/blob/250d86ea56c0e7fa375f2a84daef0a646411292a/tests/integration/test_int_dataframe.py |
Thomzoy
force-pushed
the
createDataFrame_from_pd_DataFrame
branch
from
2d1dee0 to
4e3abe4
Compare
|
Testing is done ! |
eakmanrq
approved these changes
Jan 22, 2025
|
@Thomzoy looks like the CI test failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to create a DataFrame from a
pd.DataFrameusingsession.createDataFrame, further mimicking pyspark's behaviour"