Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚑 revert Enketo buttons from <Button>s back to plain HTML #1139

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

JGreenlee
Copy link
Collaborator

Enketo requires there to be <a> elements with specific IDs for the "next" and "save" buttons. We had nested <Button>s inside these to make them match the <Button>s we use elsewhere in the UI. But in some webviews, the touch events would not bubble up from the <Button> to the <a> elements, causing the buttons to be unclickable except around the margins.

Reverting this back to just use plain <a> elements to resolve the bug. Maybe revisit <Button> later because it was nicer looking.

@shankari

Enketo requires there to be `<a>` elements with specific IDs for the "next" and "save" buttons.
We had nested `<Button>`s inside these to make them match the `<Button>`s we use elsewhere in the UI.
But in some webviews, the touch events would not bubble up from the `<Button>` to the `<a>` elements, causing the buttons to be unclickable except around the margins.

Reverting this back to just use plain `<a>` elements to resolve the bug.
Maybe revisit `<Button>` later because it was nicer looking.
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.49%. Comparing base (78b5da1) to head (79250f7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1139   +/-   ##
=======================================
  Coverage   77.49%   77.49%           
=======================================
  Files          29       29           
  Lines        1693     1693           
  Branches      370      370           
=======================================
  Hits         1312     1312           
  Misses        381      381           
Flag Coverage Δ
unit 77.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@shankari shankari merged commit de0ed4c into e-mission:master Mar 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants