Skip to content

Commit

Permalink
aria: make NavBar + NavBarButton taller
Browse files Browse the repository at this point in the history
We had the NavBar height set at 46px to match the old AngularJS + Ionic UI. It was a bit cramped. The migration is done and we no longer have to worry about that, so what's the optimal height?
Well for accessibility reasons, click zones of the action items in the navbar should ideally be at least 44x44. If the NavBarButtons are going to be 44px tall, the NavBar should be a bit taller than that. 56px looks comfortable.
  • Loading branch information
JGreenlee committed Feb 13, 2024
1 parent 72608de commit 09a0408
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions www/js/components/NavBar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const NavBar = ({ children }) => {
<Appbar.Header
statusBarHeight={0}
elevated={true}
style={{ height: 46, backgroundColor: colors.surface }}>
style={{ height: 56, backgroundColor: colors.surface }}>
{children}
</Appbar.Header>
);
Expand All @@ -30,7 +30,7 @@ export const NavBarButton = ({ children, icon, onPressAction, ...otherProps }) =
mode="outlined"
buttonColor={buttonColor}
textColor={colors.onBackground}
contentStyle={{ flexDirection: 'row', height: 36 }}
contentStyle={{ height: 44, flexDirection: 'row' }}
style={[s.btn, { borderColor: outlineColor }]}
labelStyle={s.label}
onPress={() => onPressAction()}
Expand Down

0 comments on commit 09a0408

Please sign in to comment.