Skip to content

Commit

Permalink
Merge pull request #56 from dyweb/deprecate/runner
Browse files Browse the repository at this point in the history
[deprecate][runner] Move runner to legacy
  • Loading branch information
at15 authored Feb 21, 2018
2 parents 42b6cd7 + cfbaebe commit 7360581
Show file tree
Hide file tree
Showing 10 changed files with 11 additions and 8 deletions.
4 changes: 2 additions & 2 deletions .ayi.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
dep-install:
- dep ensure
test:
- go test -v -cover ./cast/... ./config/... ./generator/... ./log/... ./requests/... ./runner/... ./structure/... ./util/...
- go test -v -cover ./cast/... ./config/... ./generator/... ./log/... ./requests/... ./structure/... ./util/...
scripts:
fmt:
- gofmt -d -l -w ./cast ./config ./log ./requests ./runner ./structure ./util
- gofmt -d -l -w ./cast ./config ./log ./requests ./structure ./util
- git status
check:
# TODO: didn't see any error so far ...
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@ install:

.PHONY: test
test:
go test -v -cover ./cast/... ./config/... ./generator/... ./log/... ./noodle/... ./requests/... ./runner/... ./structure/... ./util/...
go test -v -cover ./cast/... ./config/... ./generator/... ./log/... ./noodle/... ./requests/... ./structure/... ./util/...

.PHONY: test-log
test-log:
go test -v -cover ./log/...

.PHONY: fmt
fmt:
gofmt -d -l -w ./cast ./config ./generator ./log ./noodle ./requests ./runner ./structure ./util
gofmt -d -l -w ./cast ./config ./generator ./log ./noodle ./requests ./structure ./util

.PHONY: docker-test
docker-test:
Expand Down
11 changes: 7 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,12 @@ It has the following components:
- [Requests](requests) A pythonic wrapper for `net/http`, HTTP for Gopher.
- [Cast](cast) Convert Golang types
- [Data structure](structure) Bring Set etc. to Golang.
- [Runner](runner) A os/exec wrapper

<!--- web server - resource binding (replace go.rice)-->
Legacy

- [log v1](legacy/log) A logrus like structured logger
- [Runner](legacy/runner) A os/exec wrapper


## Dependencies

Expand Down Expand Up @@ -60,7 +63,7 @@ Currently, gommon is in a very violate state, please open issues after it become

## Acknowledgement & Improvement

Gommon is inspired by the following awesome libraries, most gommon packages have much less features a few improvements
Gommon is inspired by the following awesome libraries, most gommon packages have much less features and a few improvements
compared to packages it modeled after.

- [sirupsen/logrus](https://github.com/sirupsen/logrus) for structured logging
Expand All @@ -76,7 +79,7 @@ compared to packages it modeled after.
- [Requests](http://docs.python-requests.org/en/master/) for requests
- [benbjohnson/tmpl](https://github.com/benbjohnson/tmpl) for go template generator
- first saw it in [influxdata/influxdb](https://github.com/influxdata/influxdb/blob/master/tsdb/engine/tsm1/encoding.gen.go.tmpl)
- we put template data in `gommon.yml`, so we don't need to pass it via cli
- we put template data in `gommon.yml`, so we don't need to pass data as json via cli
- [GeertJohan/go.rice](https://github.com/GeertJohan/go.rice) for ~~rice~~ noodle
- we implemented `.gitignore` like [feature](https://github.com/at15/go.rice/issues/1) but the upstream didn't respond for the [feature request #83](https://github.com/GeertJohan/go.rice/issues/83)

Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 comments on commit 7360581

Please sign in to comment.