refactor(Go): update SlangroomExec to accept a struct as input #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puria
reviewed
Oct 16, 2024
bindings/go/README.md
Outdated
|
|
||
| // Execute Slangroom | ||
| result, err := slangroom.SlangroomExec("", contract, "", "", "", "") | ||
| result, err := slangroom.SlangroomExec() |
There was a problem hiding this comment.
should you pass input to the function like SlangroomExec(input) ?
bindings/go/slangroom.go
Outdated
| @@ -15,7 +15,16 @@ type SlangResult struct { | |||
| Logs string | |||
| } | |||
|
|
|||
| func SlangroomExec(conf string, contract string, data string, keys string, extra string, context string) (SlangResult, error) { | |||
| type SlangInput struct { | |||
There was a problem hiding this comment.
I do prefer to avoid abbreviations, prefer something like SlangroomInput?
bindings/go/slangroom.go
Outdated
| Context string | ||
| } | ||
|
|
||
| func SlangroomExec(input SlangInput) (SlangResult, error) { |
There was a problem hiding this comment.
Also prefer to refactor this to Exec... so we can call it as
slangroom.Exec
puria
approved these changes
Oct 17, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 17, 2024
# [1.2.0](v1.1.2...v1.2.0) (2024-10-17) ### Features * **go:** format struct as input and refactor the Exec function ([#10](#10)) ([4cf243b](4cf243b))
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.