Fix reading dtconfig.json #37
Conversation
|
|
| @@ -58,7 +58,7 @@ type jsonConfigFileReader struct { | |||
| // ReadConfigFromFile looks for a config file "dtconfig.json" in the current directory and attempts to parse it. | |||
| // Returns an error if the file can't be read or the parsing fails. | |||
| func (j *jsonConfigFileReader) readConfigFromFile() (fileConfig, error) { | |||
| return j.readConfigFromFileByPath("./dtconfig.json") | |||
| return j.readConfigFromFileByPath("./serverless_function_source_code/dtconfig.json") | |||
There was a problem hiding this comment.
It is unexpected that not obviously cloud-specific core functions use a hard-coded cloud-specific path. Can this maybe be used as a fallback? Or maybe we instead need instructions how to configure package.json to copy the dtconfig.json from source to build output (similar to .NET I believe)?
There was a problem hiding this comment.
Since the go exporter is only meant to be used in GCF, this is a quick fix to make it work in GCF only (at the moment it's only documented for GCF, but I believe in future this will be used in other clouds as well). Note that it will be improved in the next iteration so it handle the dtconfig.json more gracefully. I think there are few options here: 1. documenting how to set the path to the file 2. automatically set the path based on the cloud 3. something else
There was a problem hiding this comment.
IMHO both are valid points. In this PR, can it be changed to act like a fallback while keeping the current behaviour intact? I.e. look for "./dtconfig.json" first, if not found look for "./serverless_function_source_code/dtconfig.json"?
There was a problem hiding this comment.
As mentioned in #38 , this PR is redundant and should not be merged. I'll decline it.
In GCF (1st and 2nd gen functions) the source code of a function is placed at
/workspace/serverless_function_source_codefolder, but since the function is started from the parent/workspacefolder reading the dtconfig.json at "./dtconfig.json" path is not working.The PR fixes it by reading the file from ./serverless_function_source_code/dtconfig.json