Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated retrieving MetaDataUrl from endpoint url #49

Merged
merged 5 commits into from
Nov 14, 2024

Conversation

NicolajHansenPersonal
Copy link

Updated GetMetadataUrl to fetch the url from a simple request to the endpoint url.

Removed used of GetMetaDataUrl in SetCredentials because GetMetaDataUrl needs the credentials to function properly. Kept old way of find the metadataurl as a fallback

AB#21786

…endpoint url.

Removed used of GetMetaDataUrl in SetCredentials because GetMetaDataUrl needs the credentials to function properly.
Kept old way of find the metadataurl as a fallback
@frederik5480
Copy link
Contributor

I think it's odd the tabs is the length of 8 instead of 4, so when you format it, it makes it impossible to see the changes. If possible, please re-format it to the usual style of code, change your tab spacing to 4 if possible
image

@MatthiasSort
Copy link
Contributor

@NicolajHansenPersonal remember to bump the version, else it will not be released to Nuget

@NicolajHansenPersonal
Copy link
Author

@NicolajHansenPersonal remember to bump the version, else it will not be released to Nuget

Just did :)

@NicolajHansenPersonal
Copy link
Author

I think it's odd the tabs is the length of 8 instead of 4, so when you format it, it makes it impossible to see the changes. If possible, please re-format it to the usual style of code, change your tab spacing to 4 if possible image

I don't know why it has marked the almost every line as something ive changed. But i can't seem to undo it :D

Nicolaj Hansen added 2 commits November 11, 2024 13:34
@frederik5480 frederik5480 merged commit d2aaff2 into main Nov 14, 2024
1 check passed
@NicolajHansenPersonal NicolajHansenPersonal deleted the nha/21786-fetch-metadata-url-from-odataresponse branch November 14, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants