Added RetryHelper in CheckIfEndpointIsReadyForUse function. Moved dup… #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…licated code to functions. Added some more logging. Bump version to 10.0.14
DWDBE
reviewed
Dec 8, 2023
| } | ||
| if (task.IsCanceled) | ||
| { | ||
| string aditionalErrorMSG = _requestTimedOutFromGlobalSettings ? "(To change go to global settings and look for TimeoutInMilliseconds)" : ""; |
There was a problem hiding this comment.
Add a better explanation of the need for the user to change the timeout in this GS path:
/Globalsettings/Modules/DataIntegration/Job/TimeoutInMilliseconds
Since by default there will be no such "TimeoutInMilliseconds" key in the Swift Global settings file so no-one would know what to update or add :)
There was a problem hiding this comment.
well the bool "_requestTimedOutFromGlobalSettings" is only true when the Global Setting exists/is set, so that extra msg will only be shown if the solution/user has added it :)
DWDBE
approved these changes
Dec 8, 2023
frederik5480
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…licated code to functions. Added some more logging. Bump version to 10.0.14
AB#16800