Skip to content

Commit

Permalink
Merge pull request #12 from dynamicweb/frn/15477-cleanup-dependencies
Browse files Browse the repository at this point in the history
Cleanup and moving funcitionality to bases
  • Loading branch information
frederik5480 authored Oct 17, 2023
2 parents d369e71 + 46a98c3 commit 33d0ae7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 9 deletions.
4 changes: 2 additions & 2 deletions src/Dynamicweb.DataIntegration.Providers.ExcelProvider.csproj
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<Version>10.0.2</Version>
<Version>10.0.3</Version>
<AssemblyVersion>1.0.0</AssemblyVersion>
<Title>Excel Provider</Title>
<Description>Excel Provider for DataIntegration</Description>
Expand Down Expand Up @@ -28,4 +28,4 @@
<PackageReference Include="EPPlus" Version="5.6.3" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All"/>
</ItemGroup>
</Project>
</Project>
10 changes: 3 additions & 7 deletions src/ExcelProvider.cs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
namespace Dynamicweb.DataIntegration.Providers.ExcelProvider
{
[AddInName("Dynamicweb.DataIntegration.Providers.Provider"), AddInLabel("Excel Provider"), AddInDescription("Excel Provider"), AddInIgnore(false)]
public class ExcelProvider : BaseProvider, ISource, IDestination, IDropDownOptions
public class ExcelProvider : BaseProvider, ISource, IDestination, IParameterOptions
{
internal static string GetOLEDB12ConnectionString(string fileName) => $"Provider=Microsoft.ACE.OLEDB.12.0;Data Source={fileName};Extended Properties=\"Excel 12.0;HDR=Yes;IMEX=1\"";
internal static string GetOLEDB4ConnectionString(string fileName) => $"Provider=Microsoft.Jet.OLEDB.4.0;Data Source={fileName};Extended Properties=\"Excel 8.0;HDR=Yes;IMEX=1\"";
Expand Down Expand Up @@ -84,12 +84,6 @@ public override bool SchemaIsEditable
}
}

public Hashtable GetOptions(string name)
{
return new Hashtable();
}


public override Schema GetOriginalSourceSchema()
{
Schema result = new Schema();
Expand Down Expand Up @@ -444,5 +438,7 @@ public override string ValidateSourceSettings()
}
return null;
}

public IEnumerable<ParameterOption> GetParameterOptions(string parameterName) => new List<ParameterOption>();
}
}

0 comments on commit 33d0ae7

Please sign in to comment.