made RepositoriesIndexUpdate Obsolete and added logic in runjob to se… #43
Conversation
…t the job.RepositoriesIndexSettings if the provider has values in RepositoriesIndexUpdate. changed TargetGramework to net8.0 and bump version to 10.5.0 to match DataIntegration and Ecommerce
src/DynamicwebProvider.cs
Outdated
| job.RepositoriesIndexSettings = new RepositoriesIndexSettings(new Collection<string>([.. RepositoriesIndexUpdate.Split(separator, StringSplitOptions.RemoveEmptyEntries)])); | ||
| } | ||
| RepositoriesIndexUpdate = string.Empty; | ||
| job.Save(); |
There was a problem hiding this comment.
the Save operation of the job during the job running is not a good way to do it as it can lead to unpredictlable fail so the job execution can fail due to that so we need to think where to move it better
There was a problem hiding this comment.
have not found how to make it perfect, but I suggest this:
- Make a new method for those lines:
if (!string.IsNullOrEmpty(RepositoriesIndexUpdate))
if (job.RepositoriesIndexSettings?.RepositoriesIndexes?.Count == 0)
{
job.RepositoriesIndexSettings = new RepositoriesIndexSettings(new Collection([.. RepositoriesIndexUpdate.Split(separator, StringSplitOptions.RemoveEmptyEntries)]));
}
RepositoriesIndexUpdate = string.Empty;
job.Save();
}
- call it at the end of RunJob() method in the provider:
so after this line: AssortmentHandler?.RebuildAssortments();
…t the job.RepositoriesIndexSettings if the provider has values in RepositoriesIndexUpdate. changed TargetGramework to net8.0 and bump version to 10.5.0 to match DataIntegration and Ecommerce