Various fixes #13
Merged
Various fixes #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20967 - DW10: Dibs/Nets Easy - order named with cart Id in account order list when done with inline form 20966 - DW10: Dibs/Nets Easy - EmbeddedDibs template not valid Feature 19926 - DW10: Fix payment providers to shown capture amount in order backend
StanislavSmetaninSSM
requested review from
mbengtson,
frederik5480,
MrBuhl and
dw-sha
|
@frederik5480 could you please check it? It's old PR, so I did some fixes to merge it with master version. |
frederik5480
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for tasks:
Bug 20967 - DW10: Dibs/Nets Easy - order named with cart Id in account order list when done with inline form
Bug 20966 - DW10: Dibs/Nets Easy - EmbeddedDibs template not valid
Feature 19926 - DW10: Fix payment providers to shown capture amount in order backend
20967 - the problem was that for inline form we skip the module step, where we set for the cart new id (change it from "Cart" to "Order"). Before there was already one fix related with that: https://dev.azure.com/dynamicwebsoftware/Dynamicweb/_git/Dynamicweb10/pullrequest/14043
But it changes only the order id for dynamicweb, and there still will be the "CartN" name in Dibs account. It could confuse someone, so it should be fixed. To do that, used the Dibs api command "Update reference information" see: https://developer.nexigroup.com/nexi-checkout/en-EU/api/payment-v1/#v1-payments-paymentid-referenceinformation-put
20966 - Removed template tags from template
19926 - Added the common format of logs for capture operations
Also added "Dibs" icon to the provider.