Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up SBR tests, and add NUTS kwargs #573

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Conversation

Jacob-Stevens-Haas
Copy link
Member

@Jacob-Stevens-Haas Jacob-Stevens-Haas commented Oct 16, 2024

This PR implements some changes to testing:

  1. Tests involving SBR use a much smaller num_warmup, num_samples than the default arguments.
  2. nuts_kwargs added to allow fine control of the sampler (to allow faster termination in tests)
  3. column normalization is extracted from BaseOptimizer.fit so that it can be tested independently. The test no longer is parametrized across all subclasses, but rather just tests the helper function.
  4. Do a few more notebook tests in CI

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.28%. Comparing base (4d27145) to head (ddf8d6d).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #573      +/-   ##
==========================================
- Coverage   95.31%   95.28%   -0.04%     
==========================================
  Files          37       38       +1     
  Lines        4059     4069      +10     
==========================================
+ Hits         3869     3877       +8     
- Misses        190      192       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jacob-Stevens-Haas Jacob-Stevens-Haas merged commit c70acd3 into master Oct 16, 2024
7 of 8 checks passed
@Jacob-Stevens-Haas Jacob-Stevens-Haas deleted the fast_sbr_test branch October 16, 2024 22:41
@Jacob-Stevens-Haas Jacob-Stevens-Haas restored the fast_sbr_test branch October 16, 2024 22:41
@Jacob-Stevens-Haas Jacob-Stevens-Haas deleted the fast_sbr_test branch October 28, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant