Adding region constraints to pysensors PR #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and subsequent .ipynb
…niharika-krithika-mohammad-regionConstraints Updation
…//github.com/Jimmy-INL/pysensors into niharika-krithika-mohammad-regionConstraints
…ad-regionConstraints
… with radius constraints
…//github.com/niharika2999/pysensors into niharika-krithika-mohammad-regionConstraints
… updation for radius based constraints
…ctions which calculate and update the norm
…//github.com/niharika2999/pysensors into niharika-krithika-mohammad-regionConstraints
Cleaning GQR and generating unit tests
…into cleaningGQR
for checking PR
…into TestingPR For cleaning
Cleaning gqr
examples/cost_constrained_qr.ipynb
Outdated
There was a problem hiding this comment.
Is there a reason this file is deleted?
There was a problem hiding this comment.
No, this file needs to be added again. Thank you so much for catching that.
There was a problem hiding this comment.
You are welcome, and this is now fixed.
|
|
||
| """ | ||
|
|
||
| def __init__(self, U, n_basis_modes=10, **kwargs): |
There was a problem hiding this comment.
Is kwargs needed for compatibility, or can it be removed?
There was a problem hiding this comment.
It is not necessarily needed but we have included it for uniformity. Adding documentation for it.
…comments from _gqr.py,spatially_constrained_qr.ipynb and _norm_calc-py,adding kwargs documentation to _custom.py to address Josh comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optimizer GQR to pysensors for handling constrained optimization.
The types of constraints it can handle are:
The functions for these constraints are added to utils.