Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in prediction and upgrade nndmd #43

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

pswpswpsw
Copy link
Collaborator

In this version, we fixed a bug in koopman.simulate where the model was essentially doing one-step prediction over and over.

We also upgraded the NNDMD regressor so that one can train on list of trajectories even at the koopman level. Do not have to go to the lower regressor level to enjoy the benefits.

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024

Codecov Report

Merging #43 (24d4ec1) into master (4e38e25) will increase coverage by 0.29%.
The diff coverage is 86.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
+ Coverage   72.99%   73.29%   +0.29%     
==========================================
  Files          42       42              
  Lines        3781     3827      +46     
==========================================
+ Hits         2760     2805      +45     
- Misses       1021     1022       +1     
Files Coverage Δ
src/pykoopman/observables/_time_delay.py 90.56% <ø> (ø)
test/test_koopman.py 99.37% <100.00%> (+0.39%) ⬆️
src/pykoopman/koopman.py 88.35% <91.66%> (+2.11%) ⬆️
src/pykoopman/observables/_identity.py 89.28% <60.00%> (-6.72%) ⬇️
src/pykoopman/common/validation.py 82.35% <33.33%> (-7.65%) ⬇️
src/pykoopman/regression/_nndmd.py 80.53% <75.00%> (-0.38%) ⬇️

... and 6 files with indirect coverage changes

@pswpswpsw pswpswpsw merged commit 3db097b into master Feb 8, 2024
5 checks passed
@pswpswpsw pswpswpsw deleted the fix-predict-simulate-bug branch February 8, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants