Fix 'Lint & Test' and 'Playwright Tests' GitHub Actions workflows #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The NODE_VERSION variable was not being correctly set, so the `setup-node` action was defaulting to the latest LTS version (20.17.0). This was causing `better-sqlite3` problems as it relies on native code which does not target that version.
danlivings-dxw
force-pushed
the
fix/use-correct-node-version-in-github-actions
branch
from
d8324fc
to
d30692d
Compare
`nvm` no longer seems to be present when running Node in a GitHub Action. However, the correct Node version is already extracted in previous steps, so it's not actually needed here. Therefore, the setup script can just call `npm install` rather than delegate to `script/bootstrap` in a CI environment, and will do this if the first argument is `--ci`.
danlivings-dxw
force-pushed
the
fix/use-correct-node-version-in-github-actions
branch
from
d30692d
to
df52c79
Compare
danlivings-dxw
changed the title
danlivings-dxw
deleted the
fix/use-correct-node-version-in-github-actions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These workflows have suddenly stopped working with no obvious code change as the cause.
It turns out that there are two issues with the workflows, which this PR fixes:
NODE_VERSIONvariable was not being correctly set, so thesetup-nodeaction was defaulting to the latest LTS version (20.17.0).nvmis no longer available, so thescript/bootstrapscript fails.