-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ADR for storing repo data as JSON blob #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These both are sensible suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, sensible decisions well expressed
- We don't have to add any dependencies. | ||
- Initial deployments will be more simple | ||
- We won't be able to query the data using SQL | ||
- It may be harder to keep the data up to date |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add a brief note as to why here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth mentioning that we'll need to configure a container volume to enable data persistence across deployments, but otherwise this makes sense to me.
@danlivings-dxw I was thinking initially we could keep the changes committed alongside the code in order for us to avoid containerisation |
d882cc5
to
d4b7a78
Compare
@richpjames I'm not sure we'd want to commit what is essentially a file-based database to this repository, as that would leak information about private repositories and would introduce a manual step to making sure that Towtruck is displaying up-to-date information. I'd imagine an okay way to do this would be a folder named something like |
@danlivings-dxw yeah that's a good point. I wasn't aware of the number of private repositories dxw has. In #27 I've added it as a seed step that can be run on demand. |
d4b7a78
to
c25b730
Compare
No description provided.