Fix CI #11
Merged
Fix CI #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richpjames
force-pushed
the
correct-script-folder-name
branch
8 times, most recently
from
b88aa66
to
a411fce
Compare
richpjames
force-pushed
the
correct-script-folder-name
branch
from
a411fce
to
4c181c2
Compare
added 7 commits
September 5, 2024 15:59
Per https://github.com/github/scripts-to-rule-them-all the 'script' should be singular.
We need to make these files executable
Previously we were using a hardcoded node version but we want to be able to use the version specified in the .nvmrc file. This reduces the maintainence burden of the project and insures the CI always runs against the correct node verison.
For reasons beyond my understanding we can't run `nvm` in this script. So instead we have to specify where it is located. This breaks GH actions but we fix that in the next commit.
This is in order for github actions to be able to run 'source' in the bootstrap script but it makes sense to be consistent across scripts.
richpjames
force-pushed
the
correct-script-folder-name
branch
from
4c181c2
to
eebf16e
Compare
danlivings-dxw
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://github.com/github/scripts-to-rule-them-all the 'script' should be singular.