Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple calls to ActionMailer::Base#mail produces multiple Mail::Fields in the headers #162

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Multiple calls to ActionMailer::Base#mail produces multiple Mail::Fields in the headers #162

wants to merge 5 commits into from

Commits on Oct 14, 2024

  1. format: Update rubocop to match current style

    @inulty-dfe
    inulty-dfe committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    d1fa5c4 View commit details
    Browse the repository at this point in the history

  2. format: Format mailer_spec according to rubocop config

    @inulty-dfe
    inulty-dfe committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    e25d90f View commit details
    Browse the repository at this point in the history

  3. fix: Call except with * positional arguments 

      personalisation, reply_to_id and reference were not being excluded
  from the headers in view_mail and template_mail becuase they were
  passed in an array to Hash#except.

  Reference: https://rubyapi.org/3.3/o/hash#method-i-except
    @inulty-dfe
    inulty-dfe committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    b70f698 View commit details
    Browse the repository at this point in the history

  4. format: LineLength

    @inulty-dfe
    inulty-dfe committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    4ede654 View commit details
    Browse the repository at this point in the history

  5. fix: Prevent multiple calls to #mail method producing multiple fields 

      Calling #mail multiple times produces multiple Mail::Field

  the #view_mail method calls mail twice. First to generate a body which
  it can pass to the #personalisation= method.

  The second is to generate the final Mail object.

  We can prevent undesireable side effects of multiple calls to mail by
  duplicating the message before it's mutated.
    @inulty-dfe
    inulty-dfe committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    9f97605 View commit details
    Browse the repository at this point in the history