Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python versions in CI #135

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Update Python versions in CI #135

merged 3 commits into from
Dec 20, 2024

Conversation

dwhswenson
Copy link
Owner

Aside from being overdue and needed, this is largely in response to a CI failure due to a change in mdtraj-dev. If this is just that our Python CI is out of date, then the problem is on us. If we're still failing after this PR, then we'll take it upstream.

@dwhswenson
Copy link
Owner Author

Sent upstream in mdtraj/mdtraj#1913.

@dwhswenson dwhswenson added misc PR ci improvements to continuous integration labels Dec 20, 2024
@dwhswenson
Copy link
Owner Author

Been having more failures lately my guess is incompatibility of new ubuntu-latest with some old Python versions. This seems to fit, and brings makes us compliant with SPEC0.

This is ready for review and comment. Without review, I will merge this after at least 24 hours, no sooner than Sat 21 Dec 15:00 GMT (09:00 my local).

Copy link
Collaborator

@sroet sroet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 question, LGTM otherwise

.github/workflows/unit-tests.yml Outdated Show resolved Hide resolved
Copy link
Owner Author

@dwhswenson dwhswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sroet: I forgot to bump the mdtraj-release/windows/python-min build because I forgot to update this whole section! Also going to bump the mdtraj-release/windows/python-max and the mdtraj-dev/ubuntu/python-max to the new python-max=3.13.

.github/workflows/unit-tests.yml Outdated Show resolved Hide resolved
.github/workflows/unit-tests.yml Outdated Show resolved Hide resolved
Bump versions in extra include builds

Co-authored-by: Sander Roet <[email protected]>
@dwhswenson dwhswenson merged commit a4225ce into master Dec 20, 2024
7 checks passed
@dwhswenson dwhswenson deleted the update-python-versions branch December 20, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci improvements to continuous integration misc PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants