🚨 [security] [js] Update sequelize: 6.21.2 → 6.29.0 (minor)

[depfu]

---

🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!

---

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ sequelize (6.21.2 → 6.29.0) · Repo

Security Advisories 🚨

🚨 Sequelize - Default support for “raw attributes” when using parentheses

Impact

Sequelize 6.28.2 and prior has a dangerous feature where using parentheses in the attribute option would make Sequelize use the string as-is in the SQL

User.findAll({
  attributes: [
    ['count(id)', 'count']
  ]
});

Produced

SELECT count(id) AS "count" FROM "users"

Patches

This feature was deprecated in Sequelize 5, and using it prints a deprecation warning.

This issue has been patched in @sequelize/[email protected] and [email protected].

In Sequelize 7, it now produces the following:

SELECT "count(id)" AS "count" FROM "users"

In Sequelize 6, it throws an error explaining that we had to introduce a breaking change, and requires the user to explicitly opt-in to either the Sequelize 7 behavior (always escape) or the Sequelize 5 behavior (inline attributes that include () without escaping). See #15710 for more information.

Mitigations

Do not use user-provided content to build your list or attributes. If you do, make sure that attribute in question actually exists on your model by checking that it exists in the rawAttributes property of your model first.

---

A discussion thread about this issue is open at #15694
CVE: CVE-2023-22578

🚨 Unsafe fall-through in getWhereConditions

Impact

Providing an invalid value to the where option of a query caused Sequelize to ignore that option instead of throwing an error.

A finder call like the following did not throw an error:

User.findAll({
  where: new Date(),
});

As this option is typically used with plain javascript objects, be aware that this only happens at the top level of this option.

Patches

This issue has been patched in [email protected] & @sequelize/[email protected]

References

A discussion thread about this issue is open at #15698

CVE: CVE-2023-22579
Snyk: https://security.snyk.io/vuln/SNYK-JS-SEQUELIZE-3324090

🚨 Sequelize information disclosure vulnerability

Due to improper input filtering in the sequelize js library, can malicious queries lead to sensitive information disclosure.

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by 34 commits:

• feat: throw an error if attribute includes parentheses (fixes CVE-2023-22578) (#15710)
• meta: fix null test getWhereConditions (#15705)
• fix: accept undefined in where (#15703)
• fix: throw if where receives an invalid value (#15699)
• fix: update moment-timezone version (#15685)
• feat(types): use retry-as-promised types for retry options to match documentation (#15484)
• feat: add support for bigints (backport of #14485) (#15413)
• feat(postgres): add support for lock_timeout [#15345] (#15355)
• fix(oracle): remove hardcoded maxRows value (#15323)
• fix: fix parameters not being replaced when after $$ strings (#15307)
• fix(postgres): invalidate connection after client-side timeout (#15283)
• fix: remove options.model overwrite on bulkUpdate (#15252)
• fix(types): add instance.dataValues property to model.d.ts (#15240)
• meta: swap Slack links (#15159)
• fix: don't treat \ as escape in standard strings, support E-strings, support vars after ->> operator, treat lowercase e as valid e-string prefix (#15139)
• fix(types): fix TS 4.9 excessive depth error on `InferAttributes` (v6) (#15135)
• fix(types): expose legacy "types" folder in export alias ( #15123)
• feat(oracle): add support for `dialectOptions.connectString` (#15042)
• feat(snowflake): Add support for `QueryGenerator#tableExistsQuery` (#15087)
• docs: add missing ssl options for sequelize instance (v6) (#15049)
• docs(model): Added paranoid option for Model.BelongsToMany.through (#15065)
• fix(postgres): add custom order direction to subQuery ordering with minified alias (#15056)
• fix(oracle): add support for Oracle DB 18c CI (#15016)
• feat(types): add typescript 4.8 compatibility (#14990)
• fix(types): missing type for oracle dialect in v6 (#14992)
• feat(oracle): add oracle dialect support (#14638)
• fix(types): backport #14704 for v6 (#14964)
• meta: update retry-as-promised (#14966)
• fix(mariadb): do not automatically parse JSON fields (#14800)
• meta: update types property package.json (#14909)
• fix: minified aliases are now properly referenced in subqueries (v6) (#14852)
• docs: fix missing closing quotation mark (#14786)
• meta: fix alignment logo (v6) (#14745)
• fix(postgres): attach postgres error-handler earlier in lifecycle (v6) (#14731)

---

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands

@​depfu rebase

Rebases against your default branch and redoes this update

@​depfu recreate

Recreates this PR, overwriting any edits that you've made to it

@​depfu merge

Merges this PR once your tests are passing and conflicts are resolved

@​depfu close

Closes this PR and deletes the branch

@​depfu reopen

Restores the branch and reopens this PR (if it's closed)

@​depfu pause

Ignores all future updates for this dependency and closes this PR

@​depfu pause [minor|major]

Ignores all future minor/major updates for this dependency and closes this PR

@​depfu resume

Future versions of this dependency will create PRs again (leaves this PR as is)