Support block wise transfer options #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the following methods: * IsBlock2 * Block2 * SetBlock2
This commit adds the following methods: * IsBlock1 * Block1 * SetBlock1 This commit also adds a pair of new status codes: * Continue * RequestEntityIncomplete
The test validates encoding of Block1 and Block2 values for range of available szx.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds helper methods to check/get/set Block1 and Block2 options as defined in RFC 7959[0].
[0] https://tools.ietf.org/html/rfc7959
This is the second PR. I have closed the previous one due to errors in
IsBlock1IsBlock2methods. This PR contains the fixed code and adds a new test that tests for the error.