Rename Public API endpoints #8391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
flvndvd
added
the
documentation-ack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves #8266.
Vaults endpoints introduced recently are already being used (see here) so we need to support them. I'll reach out to the few workspaces.
It renames all the public API endpoints from
/vaultsto/spacesby using a NextJS rewrites instructions. This let's remove all occurrences of vaults except for an instruction in ournext.config.js.The only hack is to adapt the key in the
/api/v1/w/[wId]/vaultsto change the key based on the original url (successfully tested locally).A follow up PR (the last one) will change all logic that calls those endpoints.
Risk
Tested on
front-edge.Deploy Plan