Add permission queue workflow to update space permissions #8378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #8267.
This PR introduces a new temporal queue responsible for updating all
agent_configurationswhen a space transitions between restricted and open. Although this pattern isn't ideal, it's acceptable for a first iteration since such transitions are not expected to occur frequently.Ultimately, we know that resolving this issue would require storing the space ID within the
agent_configurations. However, this would create a duplicated source of truth. In this scenario,spaceIdswould be used to filter who can list an agent or access a conversation, while the registry would rely on the data source view to verify if the user is permitted to read data when running the assistant. Until we reach the point where we need to address User provisioning, this approach should be sufficient.Right now this PR only partially works, it only support the case a space transitions from restricted to open. We need to tackle #8268 to support the way around.
Risk
Deploy Plan