Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: toggle chat history with cmd+b #8360

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

fontanierh
Copy link
Contributor

@fontanierh fontanierh commented Oct 31, 2024

Description

Cmd + b is typically used for bold, but vscode uses it for toggling the sidebar (and we don't need bold).

Risk

Deploy Plan

@fontanierh fontanierh changed the title feat: toggle sidebar with cmd+b feat: toggle chat history with cmd+b Oct 31, 2024
@@ -1,13 +1,17 @@
import React, { useState } from "react";
import React, { useCallback, useState } from "react";

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know why it's in /sparkle/ ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Navigation is going to move to Sparkle very soon.

Copy link
Contributor

@Fraggle Fraggle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that.

@fontanierh fontanierh merged commit 7fdaaaa into main Oct 31, 2024
5 checks passed
@fontanierh fontanierh deleted the feat/toggle-sidebar-cmd-b branch October 31, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants