Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[front] - fix: manage assistant tabs #8352

Merged
merged 2 commits into from
Oct 30, 2024
Merged

[front] - fix: manage assistant tabs #8352

merged 2 commits into from
Oct 30, 2024

Conversation

JulesBelveze
Copy link
Contributor

Description

This PR aims at fixing the tab switch in the manage assistant view, which was caused by wrong attributes being accessed

Risk

Low

Deploy Plan

Deploy front

Jules added 2 commits October 30, 2024 18:28
…ants

 - Replace direct href manipulation with scope state management for tab selection
 - Ensure tab scope uses appropriate `AgentsGetViewType` type during API calls
 - Simplify activeTab computation by using scope value directly instead of label
 - Adjust assistant filtering logic to use the updated selectedTab state
 - Use object property shorthand for the scope assignment in assistant mapping
Copy link
Contributor

@fontanierh fontanierh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LVRTM

@JulesBelveze JulesBelveze merged commit 632629d into main Oct 30, 2024
3 checks passed
@JulesBelveze JulesBelveze deleted the fix/assistant-tabs branch October 30, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants