Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension: Display history of conversation + add public api url to list convos #8348

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

PopDaph
Copy link
Contributor

@PopDaph PopDaph commented Oct 30, 2024

Description

  • Add a public API route to list convo. It returns a list of ConversationWithoutContentType.
  • Extension: create a hook to fetch convos.
  • Extension: display the convos using this hook.

I need to figure out how to update our api doc, I ran npm run docs but did not change anything, will dig. Can be reviewed already.

Screenshot 2024-10-30 at 17 19 59

Risk

Can be rolled back.

Deploy Plan

Deploy front to get the new API route.

@PopDaph PopDaph requested a review from tdraier October 30, 2024 16:20
Copy link

Fails
🚫

Files in **/api/v1/ have been modified. Please add the documentation-ack label to acknowlegde that if anything changes
in a public endpoint, you need to edit the JSDoc comment
above the handler definition and/or the swagger_schemas.ts file and regenerate the documentation using npm run docs

Generated by 🚫 dangerJS against dd2657d

Comment on lines +272 to +275
case "GET":
const conversations = await getUserConversations(auth);
res.status(200).json({ conversations });
return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the swagger doc ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I said it in OP but running npm run docs did not change anything 😬

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I need to update manually the swagger doc and create the new schema for conversationwithoutcontent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed IRL we don't necessarily want to comm now on it -> need to decide how we expose the ConversationWithoutContent, not a big deal but not blocking and we want to have an MVP 😬

Copy link
Contributor

@tdraier tdraier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once swagger doc is done / swagger.json updated

@PopDaph PopDaph merged commit b70da80 into main Oct 30, 2024
4 of 5 checks passed
@PopDaph PopDaph deleted the ext-conversations-list branch October 30, 2024 19:46
@PopDaph
Copy link
Contributor Author

PopDaph commented Oct 30, 2024

Created a task assigned to me to not forget about it: https://github.com/dust-tt/tasks/issues/1568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants