Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connectors] Add a worker for Zendesk workflows #8343

Merged
merged 7 commits into from
Oct 30, 2024
Merged

Conversation

aubin-tchoi
Copy link
Contributor

Description

  • Add a worker for Zendesk's workflows.

Risk

Deploy Plan

  • Deploy connectors.

Copy link
Contributor

@spolu spolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo comment on assertNever

@@ -33,6 +29,14 @@ const {
startToCloseTimeout: "1 minute",
});

function assertNever(x: never): never {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We likely already have it available in connectors no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad for not checking, we actually don't but temporal does. Using it

@aubin-tchoi aubin-tchoi merged commit 43c97dc into main Oct 30, 2024
3 checks passed
@aubin-tchoi aubin-tchoi deleted the zendesk/worker branch October 30, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants