[sparkle] - enh: TextArea
#7767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 30, 2024 17:13
…a attributes - Modified `TextArea` component props to extend native HTML textarea element attributes for better flexibility - Removed unused `ref` and simplified logic by spreading props directly into the `textarea` element - Reworked `TextArea` stories to utilize the `defaultValue` prop instead of the `value` prop for uncontrolled component behaviour
- Package version updated to include new changes or features - Ensures consistency across package-lock.json and package.json files
Fraggle
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims at enhancing the
TextAreacomponent ofsparkle.These changes are part of the efforts to get rid of the
Poke*components we have infront. Also, this PR aligns with the efforts introduced by #7475 to have our design system to be heavily based on shacdn.References:
pokefront specific components #7747Risk
Breaking changes on
TextAreacomponents used by frontDeploy Plan
sparklePokeTextarea