-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update balancer_cowswap_amm_ethereum_liquidity.sql #6651
Conversation
Workflow run id 10679654030 approved. |
Workflow run id 10679653842 approved. |
Workflow run id 10679665656 approved. |
Workflow run id 10679665797 approved. |
Workflow run id 10679678556 approved. |
Workflow run id 10679678925 approved. |
Workflow run id 10679703075 approved. |
Workflow run id 10679703389 approved. |
Workflow run id 10679791351 approved. |
Workflow run id 10679791310 approved. |
Workflow run id 10679808690 approved. |
Workflow run id 10679808893 approved. |
Workflow run id 10679818865 approved. |
Workflow run id 10679819110 approved. |
hey @viniabussafi thanks for bringing this up! nexusmutual spells are using this type of syntax (hence I think they're fine for the time being):
there's an open issue tho: #6577 with suggestions how price feed for native tokens might change, so worth following and I agree with point raised there that using WETH for ETH prices is not the best approach (risk of depeg events). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, plz stay tuned for enhanced approach to pricing ideally released this month 🫡
Thank you for contributing to Spellbook 🪄
Update!
Please build spells in the proper subproject directory. For more information, please see the main readme, which also links to a GH discussion with the option to ask questions.
Contribution type
Please check the type of contribution this pull request is for:
Note: You can safely discard any section below which doesn't apply based on selection above
Quick update to fix the protocol_liquidity_eth and pool_liquidity_eth fields on the balancer liquidity models as the former syntax (WHERE symbol = 'ETH') was causing undesired results, likely on either one of these results:
Side note: I've seen that some nexusmutual spells also use this syntax, so tagging @tomfutago here for visibility