Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update balancer_cowswap_amm_ethereum_liquidity.sql #6651

Merged
merged 7 commits into from
Sep 4, 2024

Conversation

viniabussafi
Copy link
Contributor

@viniabussafi viniabussafi commented Sep 3, 2024

Thank you for contributing to Spellbook 🪄

Update!

Please build spells in the proper subproject directory. For more information, please see the main readme, which also links to a GH discussion with the option to ask questions.

Contribution type

Please check the type of contribution this pull request is for:

  • New spell(s)
  • Adding to existing spell lineage
  • Bug fix

Note: You can safely discard any section below which doesn't apply based on selection above


Quick update to fix the protocol_liquidity_eth and pool_liquidity_eth fields on the balancer liquidity models as the former syntax (WHERE symbol = 'ETH') was causing undesired results, likely on either one of these results:

2024-09-03 08:47 solana 0x0b931265156395f7491826c94b706e34717e5a9c60e6f668ff9301bbc347b8c1 8 ETH 0.00000884
2024-09-03 08:47 ethereum 0x0d505c03d30e65f6e9b4ef88855a47a89e4b7676 18 ETH 0.00000884

Side note: I've seen that some nexusmutual spells also use this syntax, so tagging @tomfutago here for visibility

@dune-eng
Copy link

dune-eng commented Sep 3, 2024

Workflow run id 10679654030 approved.

@dune-eng
Copy link

dune-eng commented Sep 3, 2024

Workflow run id 10679653842 approved.

@dune-eng
Copy link

dune-eng commented Sep 3, 2024

Workflow run id 10679665656 approved.

@dune-eng
Copy link

dune-eng commented Sep 3, 2024

Workflow run id 10679665797 approved.

@dune-eng
Copy link

dune-eng commented Sep 3, 2024

Workflow run id 10679678556 approved.

@dune-eng
Copy link

dune-eng commented Sep 3, 2024

Workflow run id 10679678925 approved.

@dune-eng
Copy link

dune-eng commented Sep 3, 2024

Workflow run id 10679703075 approved.

@dune-eng
Copy link

dune-eng commented Sep 3, 2024

Workflow run id 10679703389 approved.

@dune-eng
Copy link

dune-eng commented Sep 3, 2024

Workflow run id 10679791351 approved.

@dune-eng
Copy link

dune-eng commented Sep 3, 2024

Workflow run id 10679791310 approved.

@dune-eng
Copy link

dune-eng commented Sep 3, 2024

Workflow run id 10679808690 approved.

@dune-eng
Copy link

dune-eng commented Sep 3, 2024

Workflow run id 10679808893 approved.

@dune-eng
Copy link

dune-eng commented Sep 3, 2024

Workflow run id 10679818865 approved.

@dune-eng
Copy link

dune-eng commented Sep 3, 2024

Workflow run id 10679819110 approved.

@viniabussafi viniabussafi marked this pull request as ready for review September 3, 2024 09:09
@tomfutago
Copy link
Contributor

Side note: I've seen that some nexusmutual spells also use this syntax, so tagging @tomfutago here for visibility

hey @viniabussafi thanks for bringing this up! nexusmutual spells are using this type of syntax (hence I think they're fine for the time being):

  where symbol = 'ETH'
    and blockchain is null
    and contract_address is null

there's an open issue tho: #6577 with suggestions how price feed for native tokens might change, so worth following and I agree with point raised there that using WETH for ETH prices is not the best approach (risk of depeg events).

Copy link
Member

@jeff-dude jeff-dude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, plz stay tuned for enhanced approach to pricing ideally released this month 🫡

@jeff-dude jeff-dude self-assigned this Sep 3, 2024
@jeff-dude jeff-dude merged commit af59767 into duneanalytics:main Sep 4, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants